gbates101 commented on a change in pull request #5252: Use verbose name in SQL
Lab database dropdown
URL:
https://github.com/apache/incubator-superset/pull/5252#discussion_r198162687
##########
File path: superset/assets/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -155,7 +158,7 @@ class SqlEditorLeftBar extends React.PureComponent {
dataEndpoint={
'/databaseasync/api/' +
'read?_flt_0_expose_in_sqllab=1&' +
- '_oc_DatabaseAsync=database_name&' +
+ '_oc_DatabaseAsync=verbose_name&' +
Review comment:
What if I were to do the "coalescing" when creating/updating the row from
the form? For example:
- Add a checkbox to the form next to verbose name saying something like "use
database name" and have it checked by default. It would simply copy the value
of the database name field.
- If the user specifies any name that doesn't match the database name, the
checkbox unchecks and their value is persisted on save.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
