williaster commented on a change in pull request #5291: [dashboard fix] force
refresh charts under tabs
URL:
https://github.com/apache/incubator-superset/pull/5291#discussion_r198327940
##########
File path: superset/assets/src/chart/chartAction.js
##########
@@ -202,5 +202,10 @@ export function runQuery(formData, force = false, timeout
= 60, key) {
}
export function refreshChart(chart, force, timeout) {
- return dispatch => dispatch(runQuery(chart.latestQueryFormData, force,
timeout, chart.id));
+ return dispatch => {
+ if (Object.keys(chart.latestQueryFormData).length === 0) {
Review comment:
should there also be a check for whether `chart.latestQueryFormData` is
defined or is that guaranteed to be there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
