mistercrunch commented on a change in pull request #5302: [DeckGL] Raise error
with null values
URL:
https://github.com/apache/incubator-superset/pull/5302#discussion_r198668938
##########
File path: superset/viz.py
##########
@@ -2107,6 +2108,10 @@ def tupleify(s):
df[key] = list(zip(latlong.apply(lambda x: x[0]),
latlong.apply(lambda x: x[1])))
del df[spatial.get('geohashCol')]
+
+ if df[key] is None:
+ raise NullValueException('Some rows in this query contain NULL
values!')
Review comment:
the setup is kind of sweet where we use the same framework for both the
backend and frontend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
