michellethomas commented on a change in pull request #4528: Dashboard Builder v2
URL:
https://github.com/apache/incubator-superset/pull/4528#discussion_r198678331
##########
File path: superset/views/core.py
##########
@@ -518,9 +518,10 @@ class SliceAsync(SliceModelView): # noqa
class SliceAddView(SliceModelView): # noqa
list_columns = [
- 'id', 'slice_name', 'slice_link', 'viz_type',
- 'datasource_link', 'owners', 'modified', 'changed_on']
- show_columns = list(set(SliceModelView.edit_columns + list_columns))
Review comment:
@williaster do you remember why you removed `show_columns`? Not a huge deal
if there's a reason to remove this. I used it for some dashboard builder stuff
outside of superset codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
