hughhhh commented on a change in pull request #5285: [Distribution - Bar Chart]
Sort bars add asc and desc
URL:
https://github.com/apache/incubator-superset/pull/5285#discussion_r198927478
##########
File path: superset/assets/src/explore/controls.jsx
##########
@@ -449,11 +449,16 @@ export const controls = {
},
order_bars: {
- type: 'CheckboxControl',
+ type: 'SelectControl',
label: t('Sort Bars'),
- default: false,
- renderTrigger: true,
+ default: 'unsort',
description: t('Sort bars by x labels.'),
+ renderTrigger: true,
+ choices: formatSelectOptions([
+ 'unsort',
Review comment:
Why are allowing an unsort option? We should just pick `asc` or `desc` as a
default and then allow the user to toggle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
