john-bodley commented on a change in pull request #5303: [csv-hive] Use schema
form field in upload csv
URL:
https://github.com/apache/incubator-superset/pull/5303#discussion_r199312427
##########
File path: superset/db_engine_specs.py
##########
@@ -984,14 +984,22 @@ def convert_to_hive_type(col_type):
return tableschema_to_hive_types.get(col_type, 'STRING')
table_name = form.name.data
+ schema_name = form.schema.data
Review comment:
Was this just never used? It seems like it's been in the form for several
months. Per the original exception it seems like the plan was to enforce
uploading to a pre-defined schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
