mistercrunch commented on issue #5315: [cache] Providing a mechanism for disabling the datasource/database cache URL: https://github.com/apache/incubator-superset/pull/5315#issuecomment-401615596 I think it's possible for `cache_timeout` to be an empty string too (maybe once it's set and cleared on the CRUD), I think that needs to be explicitly handled and tested too. Also another good thing to do would be adding info in the help text which I think has been missing. We should make it clear we're expecting seconds and that `0` turns off the cache.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
