mistercrunch commented on issue #5265: [RfC] provide ways to hide controls on 
certain visualization types
URL: 
https://github.com/apache/incubator-superset/pull/5265#issuecomment-401617025
 
 
   @betodealmeida `hiddenControls` makes it such that the controls aren't 
rendered in the UI but not scrubbed out of `formData` allowing for the code 
that assumes `datasource` exists as a key and has a value to run without being 
changed. 
   
   A cleaner solution would make it such that the `datasource` is optional for 
certain visualization types and I think we'd have to touch the backend and 
frontend code to work around that.
   
   This change also adds support for `null` as a `sectionOverride`, allowing 
hiding a whole section easily.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to