mistercrunch commented on a change in pull request #5294: Scheduled email reports for Slices / Dashboards URL: https://github.com/apache/incubator-superset/pull/5294#discussion_r200210103
########## File path: superset/config.py ########## @@ -264,19 +265,39 @@ # Default celery config is to use SQLA as a broker, in a production setting # you'll want to use a proper broker as specified here: # http://docs.celeryproject.org/en/latest/getting-started/brokers/index.html -""" -# Example: + + class CeleryConfig(object): - BROKER_URL = 'sqla+sqlite:///celerydb.sqlite' - CELERY_IMPORTS = ('superset.sql_lab', ) - CELERY_RESULT_BACKEND = 'db+sqlite:///celery_results.sqlite' - CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}} - CELERYD_LOG_LEVEL = 'DEBUG' - CELERYD_PREFETCH_MULTIPLIER = 1 - CELERY_ACKS_LATE = True + BROKER_URL = 'sqla+sqlite:///celerydb.sqlite' + CELERY_IMPORTS = ( + 'superset.sql_lab', + 'superset.tasks', + ) + CELERY_RESULT_BACKEND = 'db+sqlite:///celery_results.sqlite' + CELERYD_LOG_LEVEL = 'DEBUG' + CELERYD_PREFETCH_MULTIPLIER = 10 Review comment: Why 10? 1 may be better. Personally I prefer leaving the messages in the queue instead of prefetching on a potentially busy worker ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
