mistercrunch commented on issue #5294: Scheduled email reports for Slices / Dashboards URL: https://github.com/apache/incubator-superset/pull/5294#issuecomment-402574099 Haven't done a very thorough review yet, but wanted to mention a slightly different approach and discuss pro/cons. I always though we'd add endpoints that would build an image on the fly and return it (say `superset/chart_image/{chart_id}.png`, `superset/dashboard_image/{dash_id}.png`), and an email feature would simply build an html email with an <img> tag pointing to it. There are some important security considerations. First the <img> approach requires auth + perms, which may not work on mobile when Superset is on intranet, and no vpn is setup on the phone. It has the advantage of being more secure in many ways, though it may just not work in many envs (mobile is not on VPN). Forwarding an email would only work for the recipient if she/he has access to the chart for instance. The binary approach has a lot of advantages too, it will just work. Maybe we need both? Maybe environments would define which method they allow? Maybe the schedule would allow you to pick which method to use in that particular case?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
