john-bodley commented on a change in pull request #5295: [sqllab] Fix sqllab
limit regex issue with sqlparse
URL:
https://github.com/apache/incubator-superset/pull/5295#discussion_r200432563
##########
File path: superset/db_engine_specs.py
##########
@@ -110,32 +110,19 @@ def apply_limit_to_sql(cls, sql, limit, database):
)
return database.compile_sqla_query(qry)
elif LimitMethod.FORCE_LIMIT:
- sql_without_limit = cls.get_query_without_limit(sql)
- return '{sql_without_limit} LIMIT {limit}'.format(**locals())
+ parsed_query = sql_parse.SupersetQuery(sql)
+ sql = parsed_query.get_query_with_new_limit(limit)
return sql
@classmethod
def get_limit_from_sql(cls, sql):
- limit_pattern = re.compile(r"""
Review comment:
Is the `get_limit_from_sql` method now obsolete?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
