john-bodley closed pull request #5354: [cache] Adding description for a zero
cache timeout
URL: https://github.com/apache/incubator-superset/pull/5354
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/connectors/druid/views.py
b/superset/connectors/druid/views.py
index 9a33c8de4a..7e50536195 100644
--- a/superset/connectors/druid/views.py
+++ b/superset/connectors/druid/views.py
@@ -179,6 +179,7 @@ class DruidClusterModelView(SupersetModelView, DeleteMixin,
YamlExportMixin): #
description_columns = {
'cache_timeout': _(
'Duration (in seconds) of the caching timeout for this cluster. '
+ 'A timeout of 0 indicates that the cache never expires. '
'Note this defaults to the global timeout if undefined.'),
}
@@ -256,6 +257,7 @@ class DruidDatasourceModelView(DatasourceModelView,
DeleteMixin, YamlExportMixin
'from the datasource list'),
'cache_timeout': _(
'Duration (in seconds) of the caching timeout for this datasource.
'
+ 'A timeout of 0 indicates that the cache never expires. '
'Note this defaults to the cluster timeout if undefined.'),
}
base_filters = [['id', DatasourceFilter, lambda: []]]
diff --git a/superset/connectors/sqla/views.py
b/superset/connectors/sqla/views.py
index b8349e57f9..d4149fce37 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -221,6 +221,7 @@ class TableModelView(DatasourceModelView, DeleteMixin,
YamlExportMixin): # noqa
'Jinja templating syntax'),
'cache_timeout': _(
'Duration (in seconds) of the caching timeout for this table. '
+ 'A timeout of 0 indicates that the cache never expires. '
'Note this defaults to the database timeout if undefined.'),
}
label_columns = {
diff --git a/superset/views/core.py b/superset/views/core.py
index bddc544371..6d7d7bc231 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -268,6 +268,7 @@ class DatabaseView(SupersetModelView, DeleteMixin,
YamlExportMixin): # noqa
'tables, this can be expensive and put strain on the system.'),
'cache_timeout': _(
'Duration (in seconds) of the caching timeout for this database. '
+ 'A timeout of 0 indicates that the cache never expires. '
'Note this defaults to the global timeout if undefined.'),
}
label_columns = {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
