williaster commented on a change in pull request #5360: [dashboard] Fix save
issue at Force_V2_Edit mode
URL:
https://github.com/apache/incubator-superset/pull/5360#discussion_r200796020
##########
File path: superset/views/core.py
##########
@@ -2169,6 +2169,8 @@ def dashboard(self, dashboard_id):
else:
dashboard_view = 'v1'
prompt_v2_conversion = not force_v1
+ if force_v2_edit:
Review comment:
is this needed for removing the `save as` dropdown option in a `v1` app?
Does this still allow you to click edit when viewing a `v1` dashboard to go to
the `v2` page?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
