williaster edited a comment on issue #5355: get rid of global `notify` URL: https://github.com/apache/incubator-superset/pull/5355#issuecomment-403175947 @mistercrunch I'm fixing tests, but I don't understand how SQL lab `alerts` worked previously, they aren't used by any sqllab component, they are only defined in App as a proptype, referenced in redux logic, and they don't seem to feed into the previous `AlertsWrapper`. Thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
