williaster commented on issue #5355: get rid of global `notify` URL: https://github.com/apache/incubator-superset/pull/5355#issuecomment-403345545 @mistercrunch @graceguo-supercat this should be good to go. I made sure `flash_messages` are displayed, but I'm not sure that it works correctly because of the way we cache sqllab redux state. when I force the backend to add flash messages (they appear in the bootstrap data), the empty messages array from the previous state takes precedence and none are displayed. in any case, this was probably broken before (and still unsure about `alerts`, from my question above. any thoughts @mistercrunch ?)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
