timifasubaa commented on a change in pull request #5413: [sqllab] remove
limiting at the display level
URL:
https://github.com/apache/incubator-superset/pull/5413#discussion_r203890207
##########
File path: superset/views/core.py
##########
@@ -2481,14 +2481,7 @@ def results(self, key):
return json_error_response(get_datasource_access_error_msg(
'{}'.format(rejected_tables)))
- payload = utils.zlib_decompress_to_string(blob)
- display_limit = app.config.get('SQL_MAX_ROW', None)
- if display_limit:
- payload_json = json.loads(payload)
- payload_json['data'] = payload_json['data'][:display_limit]
- return json_success(
- json.dumps(
- payload_json, default=utils.json_iso_dttm_ser,
ignore_nan=True))
+ return json_success(utils.zlib_decompress_to_string(blob))
Review comment:
When the blob is written in celery, it is already set with those parameters.
https://github.com/apache/incubator-superset/blob/master/superset/sql_lab.py#L229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
