john-bodley commented on a change in pull request #5434: [security] add
datasource sources
URL:
https://github.com/apache/incubator-superset/pull/5434#discussion_r203890488
##########
File path: superset/connectors/sqla/models.py
##########
@@ -325,6 +325,10 @@ def name(self):
return self.table_name
return '{}.{}'.format(self.schema, self.table_name)
+ @property
Review comment:
We should probably add some unit tests here. The SQL is optional for the
SQLA models and thus there needs to be logic to return either `self.name` or
the tables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
