timifasubaa closed pull request #5413: [sqllab] remove limiting at the display
level
URL: https://github.com/apache/incubator-superset/pull/5413
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/sql_lab.py b/superset/sql_lab.py
index 34a9eeb9e3..b45cbbb64b 100644
--- a/superset/sql_lab.py
+++ b/superset/sql_lab.py
@@ -226,7 +226,8 @@ def handle_error(msg):
if store_results:
key = '{}'.format(uuid.uuid4())
logging.info('Storing results in results backend, key: {}'.format(key))
- json_payload = json.dumps(payload, default=utils.json_iso_dttm_ser)
+ json_payload = json.dumps(
+ payload, default=utils.json_iso_dttm_ser, ignore_nan=True)
cache_timeout = database.cache_timeout
if cache_timeout is None:
cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT', 0)
diff --git a/superset/views/core.py b/superset/views/core.py
index e64f1ff4fb..4f34968fca 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2481,14 +2481,7 @@ def results(self, key):
return json_error_response(get_datasource_access_error_msg(
'{}'.format(rejected_tables)))
- payload = utils.zlib_decompress_to_string(blob)
- display_limit = app.config.get('SQL_MAX_ROW', None)
- if display_limit:
- payload_json = json.loads(payload)
- payload_json['data'] = payload_json['data'][:display_limit]
- return json_success(
- json.dumps(
- payload_json, default=utils.json_iso_dttm_ser,
ignore_nan=True))
+ return json_success(utils.zlib_decompress_to_string(blob))
@has_access_api
@expose('/stop_query/', methods=['POST'])
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
