williaster commented on issue #5398: Re-add dashboard short links URL: https://github.com/apache/incubator-superset/pull/5398#issuecomment-406648996 I'm on PTO and will take a look at this next week when I'm back. Re the UI We'd like all links in the drop-down to simplify the top level UI. We've also gotten rid of use of icons as they're often cryptic. Can you match the aesthetics of the current drop-down options? On Wed, Jul 18, 2018 at 21:22 Jay Lindquist <[email protected]> wrote: > It's the same as the change by @hughhhh <https://github.com/hughhhh> > > [image: dashboard-short-url-modal] > <https://user-images.githubusercontent.com/222699/42919732-f3af0654-8ad8-11e8-83ed-e38708d73149.PNG> > > When a user does not have the ability to save the dashboard: > > [image: dashboard-short-url-modal-nosave] > <https://user-images.githubusercontent.com/222699/42919739-00913d88-8ad9-11e8-8aac-d05bc01c5c8e.PNG> > > — > You are receiving this because your review was requested. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-superset/pull/5398#issuecomment-406142402>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AEScifN3JNrXTBwHSOXhJxzCnB37N9tMks5uH_t3gaJpZM4VROD9> > . > -- Chris Data Visualization San Francisco
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
