hughhhh commented on a change in pull request #5365: change datetime format
prior to json dump
URL:
https://github.com/apache/incubator-superset/pull/5365#discussion_r204282750
##########
File path: superset/connectors/druid/models.py
##########
@@ -514,6 +514,12 @@ def schema_perm(self):
"""Returns schema permission if present, cluster one otherwise."""
return security_manager.get_schema_perm(self.cluster, self.schema)
+ def get_col(self, col_name):
+ columns = self.columns
+ for col in columns:
Review comment:
Can we get a unit test here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
