betodealmeida commented on a change in pull request #5380: Add time grain
blacklist and addons to config.py
URL:
https://github.com/apache/incubator-superset/pull/5380#discussion_r204514806
##########
File path: superset/db_engine_specs.py
##########
@@ -52,6 +52,35 @@
Grain = namedtuple('Grain', 'name label function duration')
Review comment:
I think we can get rid of the `name` attribute in `Grain`. I checked the
code and it seems like it's not being used anywhere, and grains can be uniquely
identified by the duration now that they're ISO durations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
