williaster commented on a change in pull request #5177: Time shift difference
URL:
https://github.com/apache/incubator-superset/pull/5177#discussion_r204590778
##########
File path: superset/assets/package.json
##########
@@ -68,6 +68,7 @@
"geojson-extent": "^0.3.2",
"geolib": "^2.0.24",
"immutable": "^3.8.2",
+ "is-react": "^1.1.1",
Review comment:
@betodealmeida @mistercrunch was it necessary to add this dependency for
functionality that is already provided by React natively?
from the
[source](https://github.com/treyhuffine/is-react/blob/master/index.js#L32):
`React.isValidElement(typeElement)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
