villebro commented on issue #5380: Add time grain blacklist and addons to config.py URL: https://github.com/apache/incubator-superset/pull/5380#issuecomment-407400006 @betodealmeida I tried to remove `name` from Grain and updating `time_column_grains()` and `data()` in `connectors/sqla/models.py`, but got slightly overwhelmed by the frontend code. For instance, `controls.jsx` seems to have similar but slightly different grains, and am unsure where these definitions are used: https://github.com/apache/incubator-superset/blob/bea0a0aa1590d073365ecf74d75a054643dbe3b7/superset/assets/src/explore/controls.jsx#L750-L776 I'm sure I will be able to sort out how the frontend logic works, but it will take time, so I propose merging this and removing `name` in a separate PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
