williaster commented on a change in pull request #5469: Update BigNumber
URL:
https://github.com/apache/incubator-superset/pull/5469#discussion_r205905498
##########
File path: superset/assets/src/visualizations/big_number.css
##########
@@ -1,31 +1,40 @@
-.big_number g.axis text,
-.big_number_total g.axis text {
- font-size: 10px;
- font-weight: normal;
- color: gray;
- fill: gray;
- text-anchor: middle;
- alignment-baseline: middle;
- font-weight: none;
+.big_number {
+ font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Roboto,Oxygen,Ubuntu,Cantarell,Open Sans,Helvetica Neue,sans-serif;
+ position: relative;
+ overflow: hidden;
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
}
-.big_number text.big,
-.big_number_total text.big{
- stroke: black;
- text-anchor: middle;
- fill: black;
+.big_number.no_trendline .big_number_subheader_line {
+ padding-bottom: 0.3em;
}
-.big_number g.tick line,
-.big_number_total g.tick line{
- stroke-width: 1px;
- stroke: grey;
+.big_number_text_container {
+ overflow: hidden;
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
}
-.big_number .domain,
-.big_number_total .domain{
- fill: none;
- stroke: black;
- stroke-width: 1;
+.big_number_header_line {
+ position: relative;
+ font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Roboto,Oxygen,Ubuntu,Cantarell,Open Sans,Helvetica Neue,sans-serif;
Review comment:
makes sense đź‘Ťand I agree no obvious work around. We could possibly add a
comment in the css that removing it would potentially break proper sizing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
