mistercrunch commented on a change in pull request #5515: convert position to
v2 for Superset load_examples
URL:
https://github.com/apache/incubator-superset/pull/5515#discussion_r206412469
##########
File path: superset/data/__init__.py
##########
@@ -36,6 +36,21 @@
misc_dash_slices = [] # slices assembled in a "Misc Chart" dashboard
+def update_slice_ids(layout_dict, slices):
+ charts = list(
+ filter(
+ lambda component: (
Review comment:
[optional] the more pythonic way of writing this is by using a list
comprehension, something like
```python
charts = [
o for o in layout_dict.values()
if isinstance(component, dict) and component['type'] ==
'DASHBOARD_CHART_TYPE'
]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
