john-bodley opened a new pull request #5525: [ad-hoc filters] Fixing issue with legacy filters URL: https://github.com/apache/incubator-superset/pull/5525 This PR fixes an issue with https://github.com/apache/incubator-superset/pull/5206. Previously dashboard filters (`extra_filters` in the form-data defined via the legacy definition) and saved URLs with legacy filter definitions wouldn't be correctly handled in the explorer UI as they weren't included in as part of the ad-hoc filters. The solution is to convert these filters to ad-hoc filters (be it by transform legacy filters or merging the extra filters) to ensure they're correctly handled in the UI. These filters are then split into the base filters (like previously) to ensure correct handling by the various engines. Note in the future we should migrate away from having legacy filters defined anywhere. to: @GabeLoins @graceguo-supercat @michellethomas @mistercrunch @timifasubaa
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
