graceguo-supercat commented on a change in pull request #5515: convert position
to v2 for Superset load_examples
URL:
https://github.com/apache/incubator-superset/pull/5515#discussion_r206714308
##########
File path: superset/data/__init__.py
##########
@@ -33,7 +33,17 @@
DATA_FOLDER = os.path.join(config.get("BASE_DIR"), 'data')
-misc_dash_slices = [] # slices assembled in a "Misc Chart" dashboard
+misc_dash_slices = set() # slices assembled in a "Misc Chart" dashboard
Review comment:
in `load_multi_line`, some slices are loaded twice. I have to use Set to
store misc_dash's slices name, otherwise same slices are added into list twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
