john-bodley opened a new pull request #5533: [ad-hoc filters] Remove legacy split in /explore URL: https://github.com/apache/incubator-superset/pull/5533 This PR removes the unnecessary step of splitting ad-hoc filters into legacy filters for the `/explore` endpoint. This merely unnecessarily pollutes (in a non-harmful way) the form-data (including that in the URL) with legacy constructs. These clauses are ignored given that the `adhoc_filters` field is guaranteed to exist (by construction). Note the only place we currently need to split ad-hoc filters to legacy (base) filters in the `BaseViz.query_obj(...)` as the query logic still uses the legacy constructs. Note a migration is not needed here given the code correctly converts and then removes the legacy constructs, but could be merited for cleaning up erroneous fields in the form-data. to: @GabeLoins @graceguo-supercat @michellethomas @mistercrunch @timifasubaa
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
