jeffreythewang opened a new pull request #5542: [ad-hoc filters] Use SelectControl for groupable filters with filter select enabled URL: https://github.com/apache/incubator-superset/pull/5542 Previously, whether the ad-hoc filter popover value field was a `SelectControl` or free form input was dependent on whether there are options to choose from. This creates some weird situations where the field is a free form input for a few seconds and then becomes a select control (because the request to pre-populate the options can take a while). **Before** (the weird situation):  Instead, I think `SelectControl` should be rendered if filter select is enabled and if the column is groupable (it doesn't make sense to query for 1000+ possible ID values, and calling filter select on a field like a sum just runs forever). **After**:  If users do not want a pre-populated value, nor to wait for the pre-populate request to finish running, they can create an option the same way as they could before ad-hoc filters. I'm not sure if this will conflict with deprecation of legacy filters. @john-bodley @mistercrunch @michellethomas @GabeLoins @graceguo-supercat
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
