john-bodley commented on issue #5540: Fix superset error message flow
URL: 
https://github.com/apache/incubator-superset/pull/5540#issuecomment-409744619
 
 
   Don't you still want to return the full table name in `rejected_datasources` 
as the table may not contain the schema when parsing the SQL? Also it's 
probably worth double checking the function naming is consistent. There's 
references to datasource, table, etc. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to