mistercrunch commented on a change in pull request #5523: [sql lab] simplify
the visualize flow
URL:
https://github.com/apache/incubator-superset/pull/5523#discussion_r207096734
##########
File path: superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
##########
@@ -0,0 +1,167 @@
+/* eslint no-undef: 2 */
+import moment from 'moment';
+import React from 'react';
+import PropTypes from 'prop-types';
+import { bindActionCreators } from 'redux';
+import { connect } from 'react-redux';
+import { Alert } from 'react-bootstrap';
+import Dialog from 'react-bootstrap-dialog';
+
+import shortid from 'shortid';
+import { exportChart } from '../../explore/exploreUtils';
+import * as actions from '../actions';
+import InfoTooltipWithTrigger from '../../components/InfoTooltipWithTrigger';
+import { t } from '../../locales';
+import Button from '../../components/Button';
+
+const propTypes = {
+ actions: PropTypes.object.isRequired,
+ query: PropTypes.object,
+ errorMessage: PropTypes.string,
+ timeout: PropTypes.number,
+ database: PropTypes.object.isRequired,
+};
+const defaultProps = {
+ query: {},
+};
+
+class ExploreResultsButton extends React.PureComponent {
+ constructor(props) {
+ super(props);
+ this.state = {
+ hints: [],
+ };
+ this.visualize = this.visualize.bind(this);
Review comment:
We should introduce this decorator and attack the whole repo with it. In the
meantime we have one less dependency and consistent-ish code (we have some
binding done outside the constructors in many places...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
