williaster commented on issue #5552: Add option for BigNumber to not start y-axis at 0 URL: https://github.com/apache/incubator-superset/pull/5552#issuecomment-410157441 I believe we have a y-min/max setting for the nvd3 line chart, but I think a boolean is better here. In person we discussed actually preferring the option "start y-axis at 0" (rather than the negated version it is now), the issue is that we want the default to be `true` in that case, and since slices don't have this parameter yet it would default to `falsy`. In thinking about this more though, we could use the preferred "start y-axis at 0," and then check if the value `=== false`. that way, although current slices would have an `undefined`, it would result in a 0 y-axis as we want because `=== false` is `false`. thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
