mahendra commented on a change in pull request #5294: Scheduled email reports
for Slices / Dashboards
URL:
https://github.com/apache/incubator-superset/pull/5294#discussion_r207768254
##########
File path: setup.py
##########
@@ -96,6 +96,8 @@ def get_git_sha():
'thrift-sasl>=0.2.1',
'unicodecsv',
'unidecode>=0.04.21',
+ 'croniter==0.3.24',
+ 'selenium==3.12.0',
],
Review comment:
@villebro Noted. I just updated the code and removed the pinning. Pushed it
to github.
To clarify, my worry was not about the ability to fix breakages. Rather it
was to avoid breaking deploys. Specifically when someone installs/upgrades to
superset==0.27.0 and their setup script accidentally upgrades selenium to an
incompatible version. This could leave them with a broken deploy. We could fix
it once we get bug reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
