williaster commented on a change in pull request #5186: Implement a React-based table editor URL: https://github.com/apache/incubator-superset/pull/5186#discussion_r208045943
########## File path: superset/assets/src/CRUD/CollectionTable.jsx ########## @@ -0,0 +1,220 @@ +import React from 'react'; Review comment: I think you could simplify this component significantly by separating the table component from the row component (ie different files instead of `this.renderHeaderRow()`, etc.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
