williaster commented on issue #5524: A tagging system for dashboards, charts and queries URL: https://github.com/apache/incubator-superset/pull/5524#issuecomment-411311776 thanks @betodealmeida ! I agree regarding `react-router`/it could be added in the future, thanks for looking at it. It looks like we also already make calls like `new URI()`[using `uri-js`](https://github.com/apache/incubator-superset/blob/c06531950869d84a50e7914b945ba6ceb2a5c179/superset/assets/src/explore/exploreUtils.js#L36). Do we need both `uri-js` and the `url-polyfill`? If you'd rather use the latter can we get rid of the former?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
