mistercrunch commented on issue #5269: Filters as a native dashboard (v2) 
construct
URL: 
https://github.com/apache/incubator-superset/issues/5269#issuecomment-412761576
 
 
   Deprecating filter_box may be tricky as you'll need a [perhaps complex] db 
migration script, and that may leave the layout of dashboards messed up (users 
would find an empty hole).
   
   Personally I'm thinking we could just put the viz type on life support and 
add a "deprecated" stamp on the thumbnail png, or making it inaccessible from 
the viz type switcher modal. Eventually could encourage dashboard owners to 
remove those from their dashboards, maybe some alert when in edit mode.
   
   I think the add/edit filter modal needs more options: whether it should be 
based on a metric, sorting specification, allow_multi_choices.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to