codecov-io edited a comment on issue #5567: make filters use security manager URL: https://github.com/apache/incubator-superset/pull/5567#issuecomment-410868958 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5567?src=pr&el=h1) Report > Merging [#5567](https://codecov.io/gh/apache/incubator-superset/pull/5567?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/aa14bac5c7619e80a8a7af1b5fe1d09691b16c35?src=pr&el=desc) will **increase** coverage by `0.13%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5567?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5567 +/- ## ========================================= + Coverage 63.36% 63.5% +0.13% ========================================= Files 351 360 +9 Lines 22259 22888 +629 Branches 2470 2549 +79 ========================================= + Hits 14104 14534 +430 - Misses 8140 8339 +199 Partials 15 15 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5567?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.99% <ø> (+0.01%)` | :arrow_up: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `68% <100%> (+1.1%)` | :arrow_up: | | [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU2VsZWN0QXN5bmNDb250cm9sLmpzeA==) | `56% <0%> (-14%)` | :arrow_down: | | [...erset/assets/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2FjdGlvbnMvZXhwbG9yZUFjdGlvbnMuanM=) | `56.94% <0%> (-12.29%)` | :arrow_down: | | [superset/assets/src/components/Button.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0J1dHRvbi5qc3g=) | `90.9% <0%> (-9.1%)` | :arrow_down: | | [...ets/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9FeHBsb3JlUmVzdWx0c0J1dHRvbi5qc3g=) | `82.41% <0%> (-4.77%)` | :arrow_down: | | [...rc/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQ2hlY2tib3hDb250cm9sLmpzeA==) | `89.47% <0%> (-3.86%)` | :arrow_down: | | [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVGltZVNlcmllc0NvbHVtbkNvbnRyb2wuanN4) | `88.46% <0%> (-2.65%)` | :arrow_down: | | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRGF0YXNvdXJjZUNvbnRyb2wuanN4) | `66.17% <0%> (-1.83%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.09% <0%> (-1.48%)` | :arrow_down: | | ... and [42 more](https://codecov.io/gh/apache/incubator-superset/pull/5567/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5567?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5567?src=pr&el=footer). Last update [aa14bac...8be397a](https://codecov.io/gh/apache/incubator-superset/pull/5567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
