williaster commented on a change in pull request #5652: [sqllab] call out
transient state of tabs to users
URL:
https://github.com/apache/incubator-superset/pull/5652#discussion_r210786279
##########
File path: superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -126,12 +126,15 @@ class TabbedSqlEditors extends React.PureComponent {
const activeQueryEditor = this.activeQueryEditor();
const qe = {
title: t('Untitled Query %s', queryCount),
- dbId: (activeQueryEditor && activeQueryEditor.dbId) ?
- activeQueryEditor.dbId :
- this.props.defaultDbId,
- schema: (activeQueryEditor) ? activeQueryEditor.schema : null,
+ dbId:
+ activeQueryEditor && activeQueryEditor.dbId
+ ? activeQueryEditor.dbId
+ : this.props.defaultDbId,
+ schema: activeQueryEditor ? activeQueryEditor.schema : null,
autorun: false,
- sql: 'SELECT ...',
+ sql: `${t(
Review comment:
this is the only functional change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
