betodealmeida commented on a change in pull request #5767: Fix multilayer
geoviz and color picker error
URL:
https://github.com/apache/incubator-superset/pull/5767#discussion_r213513166
##########
File path: superset/assets/src/visualizations/deckgl/multi.jsx
##########
@@ -33,7 +33,13 @@ function deckMulti(slice, payload, setControlValue) {
// Filters applied to multi_deck are passed down to underlying charts
// note that dashboard contextual information (filter_immune_slices and
such) aren't
// taken into consideration here
- let filters = subslice.form_data.filters.concat(fd.filters);
+ let filters = [];
+ if (subslice.form_data.filters) {
+ filters = filters.concat(subslice.form_data.filters);
Review comment:
Nit, can you use array spread here instead of `concat`?
```javascript
filters = [...filters, ...subslice.form_data.filters];
```
Same below, in the two uses of `concat`. It's the new preferred way of
concatenating arrays.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
