williaster commented on a change in pull request #5772: [superset-client] add
`SupersetClient`, refactor app
URL:
https://github.com/apache/incubator-superset/pull/5772#discussion_r213572859
##########
File path: superset/assets/.eslintrc
##########
@@ -26,7 +27,7 @@
"no-mixed-operators": 0,
"no-continue": 0,
"no-bitwise": 0,
- "no-undef": 0,
+ "no-undef": 1,
Review comment:
warning for this, turning this off is BAD!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]