williaster commented on a change in pull request #5718: [SIP-5] Refactor and
repair partition
URL:
https://github.com/apache/incubator-superset/pull/5718#discussion_r213810852
##########
File path: superset/assets/src/visualizations/partition.js
##########
@@ -1,19 +1,14 @@
/* eslint no-param-reassign: [2, {"props": false}] */
-/* eslint no-use-before-define: ["error", { "functions": false }] */
import d3 from 'd3';
-import {
- d3TimeFormatPreset,
-} from '../modules/utils';
+import PropTypes from 'prop-types';
+import { hierarchy } from 'd3-hierarchy';
+import { d3TimeFormatPreset } from '../modules/utils';
import { getColorFromScheme } from '../modules/colors';
-
import './partition.css';
-d3.hierarchy = require('d3-hierarchy').hierarchy;
Review comment:
interesting 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
