youngyjd commented on a change in pull request #5767: Fix multilayer geoviz and
color picker error
URL:
https://github.com/apache/incubator-superset/pull/5767#discussion_r213840292
##########
File path: superset/assets/src/visualizations/deckgl/layers/arc.jsx
##########
@@ -40,17 +41,17 @@ function deckArc(slice, payload, setControlValue) {
};
if (fd.autozoom) {
- viewport = common.fitViewport(viewport, getPoints(payload.data.arcs));
+ viewport = common.fitViewport(viewport, getPoints(payload.data.features));
Review comment:
Seems not. `data` is not defined in `function deckArc(slice, payload,
setControlValue){}` so I feel using `data` here will not work. It is extracted
in `function getLayer(fd, payload, slice){}` instead.
```
function getLayer(fd, payload, slice) {
const data = payload.data.features;
const sc = fd.color_picker;
const tc = fd.target_color_picker;
return new ArcLayer({
id: `path-layer-${fd.slice_id}`,
data,
getSourceColor: d => d.sourceColor || d.color || [sc.r, sc.g, sc.b, 255
* sc.a],
getTargetColor: d => d.targetColor || d.color || [tc.r, tc.g, tc.b, 255
* tc.a],
strokeWidth: (fd.stroke_width) ? fd.stroke_width : 3,
...common.commonLayerProps(fd, slice),
});
}
function deckArc(slice, payload, setControlValue) {
const fd = slice.formData;
let viewport = {
...fd.viewport,
width: slice.width(),
height: slice.height(),
};
if (fd.autozoom) {
viewport = common.fitViewport(viewport,
getPoints(payload.data.features));
}
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
