betodealmeida opened a new pull request #5777: Fix redirect to SQL Lab URL: https://github.com/apache/incubator-superset/pull/5777 This PR fix a few things: 1. The SQL Lab redirect was not working correctly, since changes to the form controls were not being picked up. Instead, the auto-populated query corresponded to the **saved** chart, not the one being visualized. 2. The redirect code was using the [URL interface](https://developer.mozilla.org/en-US/docs/Web/API/URL) without a polyfill. I changed the code to use `uri.js`, which is a dependency. 3. The error message was using the `notify` code that was removed. I changed it to use the chart alerting instead.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
