williaster commented on a change in pull request #5707: [SIP-5] Refactor table
URL:
https://github.com/apache/incubator-superset/pull/5707#discussion_r214215633
##########
File path: superset/assets/spec/javascripts/visualizations/table_spec.jsx
##########
@@ -1,12 +1,13 @@
import { describe, it } from 'mocha';
import { expect } from 'chai';
import $ from 'jquery';
-
import '../../helpers/browser';
-import { d3format } from '../../../src/modules/utils';
-
import tableVis from '../../../src/visualizations/table';
+// Fix `Option is not defined`
+//
https://stackoverflow.com/questions/39501589/jsdom-option-is-not-defined-when-running-my-mocha-test
+global.Option = window.Option;
Review comment:
I'm not sure if it'd be useful to put this into the
`spec/helpers/browser.js` file, that's where other things like this currently
are. but once we move to packages, this type of config should be specific to
each package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
