williaster commented on a change in pull request #5693: Adding simple Cypress
tests
URL:
https://github.com/apache/incubator-superset/pull/5693#discussion_r214433419
##########
File path: superset/assets/src/explore/components/Control.jsx
##########
@@ -84,6 +84,7 @@ export default class Control extends React.PureComponent {
const divStyle = this.props.hidden ? { display: 'none' } : null;
return (
<div
+ data-test={this.props.name}
Review comment:
but we use css selectors elsewhere in these tests right? that seems
unavoidable to some extent. If you feel strongly about it let's go with this
pattern but perhaps you could set it to `data-name` so it indicates what the
value is rather than just 'test'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
