villebro commented on issue #5294: [SIP-3] Scheduled email reports for Slices / Dashboards URL: https://github.com/apache/incubator-superset/pull/5294#issuecomment-417850641 @mahendra Added a few comments, will add some more tomorrow. Some general comments: - With the risk of introducing feature creep, I think it would be good to have a one-off emailing feature in the scheduling UI to test what the report looks like. It would make it easier to test if email settings work correctly, and also check if the email report renders properly. - Another feature that would be valuable in the UI (not for this release, but later): Custom resolution (if a report looks better in some resolution other than that defined in `superset_config.py`), - Outside of the scope of this PR, but `EMAIL_NOTIFICATIONS` is defined twice in `config.py`, and is slightly misleading for the dry run feature. I would perhaps add a specifig debugging flag for email schedules that controls dry run that would be called `SCHEDULED_EMAIL_DEBUG_MODE` or something similar.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
