mahendra commented on issue #5294: [SIP-3] Scheduled email reports for Slices / 
Dashboards
URL: 
https://github.com/apache/incubator-superset/pull/5294#issuecomment-417960477
 
 
   @villebro thank you for the detailed review.
   
   - The test email feature is a good one to have. We can make it happen as 
follows. When an email report is created/modified, we can send a mail 
immediately to
     - **the creator** of the schedule OR
     - **the recipients** mentioned in the schedule. (This is how systems like 
Looker do it)
   
     Let me know your preference on this. I can add it to the current branch.
     Alternately, we need to plan a UI for this.
   
     Also, do you want me to do it in this PR or as a follow up feature? (I am 
leaning to doing it as a follow up feature as soon as this is merged in)
   
   - Custom resolution was a feature which someone else requested too. I will 
do it in a separate PR.
   - Good point. I have pushed up a change for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to