zhaoyongjie commented on a change in pull request #5809: fix superset
export_datasources command in python3 failed
URL:
https://github.com/apache/incubator-superset/pull/5809#discussion_r214965807
##########
File path: superset/cli.py
##########
@@ -268,7 +268,7 @@ def import_datasources(path, sync, recursive=False):
'--datasource-file', '-f', default=None,
help='Specify the the file to export to')
@click.option(
- '--print', '-p',
+ '--print-stdout', '-p',
Review comment:
The function export_datasources parameter is print_stdout, if you use print,
it will cause error, like:
```
return callback(*args, **kwargs)
File
"/Users/yongjie.zhao/.virtualenvs/incubator-superset-py3/lib/python3.6/site-packages/click/decorators.py",
line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File
"/Users/yongjie.zhao/.virtualenvs/incubator-superset-py3/lib/python3.6/site-packages/flask/cli.py",
line 257, in decorator
return __ctx.invoke(f, *args, **kwargs)
File
"/Users/yongjie.zhao/.virtualenvs/incubator-superset-py3/lib/python3.6/site-packages/click/core.py",
line 535, in invoke
return callback(*args, **kwargs)
TypeError: export_datasources() got an unexpected keyword argument 'print'
```
and click version is 6.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
