codecov-io edited a comment on issue #5827: [WIP] Improve column/alias handling 
for case insensitive engines
URL: 
https://github.com/apache/incubator-superset/pull/5827#issuecomment-418905069
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5827?src=pr&el=h1)
 Report
   > Merging 
[#5827](https://codecov.io/gh/apache/incubator-superset/pull/5827?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/5616d7bdd72cb6d41caaf8733823d5d7dbe26abb?src=pr&el=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `92.3%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/5827/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5827?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5827      +/-   ##
   ==========================================
   + Coverage    63.7%   63.74%   +0.04%     
   ==========================================
     Files         366      368       +2     
     Lines       23146    23230      +84     
     Branches     2599     2600       +1     
   ==========================================
   + Hits        14746    14809      +63     
   - Misses       8385     8406      +21     
     Partials       15       15
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/5827?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `81.23% <100%> (+0.1%)` | :arrow_up: |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `55.11% <50%> (-0.09%)` | :arrow_down: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `81.49% <91.66%> (+0.13%)` | :arrow_up: |
   | 
[...ts/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWIuanN4)
 | `82.43% <0%> (-3.87%)` | :arrow_down: |
   | 
[superset/assets/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQ29udHJvbC5qc3g=)
 | `38.09% <0%> (ø)` | :arrow_up: |
   | 
[superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==)
 | `100% <0%> (ø)` | :arrow_up: |
   | 
[superset/assets/src/visualizations/filter\_box.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9maWx0ZXJfYm94LmpzeA==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...uperset/assets/src/visualizations/paired\_ttest.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wYWlyZWRfdHRlc3QuanN4)
 | | |
   | 
[superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4)
 | | |
   | 
[.../assets/src/visualizations/BigNumber/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIvQmlnTnVtYmVyLmpzeA==)
 | `0% <0%> (ø)` | |
   | ... and [8 
more](https://codecov.io/gh/apache/incubator-superset/pull/5827/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5827?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5827?src=pr&el=footer).
 Last update 
[5616d7b...8fb0eee](https://codecov.io/gh/apache/incubator-superset/pull/5827?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to