john-bodley commented on a change in pull request #5844: add timing to stats
logger
URL:
https://github.com/apache/incubator-superset/pull/5844#discussion_r216195632
##########
File path: superset/stats_logger.py
##########
@@ -29,6 +29,9 @@ def decr(self, key):
"""Decrement a counter"""
raise NotImplementedError()
+ def timing(self, key, time_in_milliseconds):
Review comment:
If I'm reading
[this](https://github.com/jsocol/pystatsd/blob/fadc6ccc768c327c830044dee34dd0271302e8d4/statsd/client/base.py#L26)
correctly the value can be either ms or a `timedelta` object, thus I wonder if
`time_in_milliseconds` should simply be `delta` or `value` (for consistency).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
